Merged
Conversation
Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann
requested review from
David-Development and
tobiasKaminsky
Member
This only works for Kotlin, right? But all samples are in Java? |
Member
Author
|
No, this is a Java 10 feature and we are using Java 11 🙂 |
tobiasKaminsky
approved these changes
Nov 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActivityandFragment- they are nearly identical and the duplication make everything quite complicatedvarkeyword - makes it easier to focus on the actual stuffNextcloudAPIwithout explicitApiConnectedListenercallback (see Make NextcloudAPI constructor less verbose #400)<queries>section. This can be omitted, since it is part of SSO lib0.6.0(see Add queries to Manifest so that lib can find Files App for SDK>=30 #282)Signed-off-by: Stefan Niedermann info@niedermann.it